NIFI-16045: Initial API for Processor / Connector Backlog#98
Merged
Conversation
pvillard31
reviewed
Jun 25, 2026
| * @param instant the moment at which the component was last observed as fully caught up | ||
| * @return a new Backlog | ||
| */ | ||
| public static Backlog lastCaughtUp(final Instant instant) { |
Contributor
There was a problem hiding this comment.
Since lastCaughtUp(Instant) is documented as useful for combining with a count-only Backlog, but plus() downgrades any count-only combine with it to AT_LEAST, is that downgrade intended when the timestamp adds no numeric uncertainty?
| } | ||
|
|
||
| @Test | ||
| public void testCaughtUpFactoryProducesZerosAndTimestamp() { |
Contributor
There was a problem hiding this comment.
Can we add a small test for the builder rejecting negative flowFiles, bytes, and records values?
| * @return a Future that will be completed when the draining is complete | ||
| */ | ||
| CompletableFuture<Void> drainFlowFiles(FlowContext flowContext); | ||
|
|
Contributor
There was a problem hiding this comment.
Is the extra blank line at the end of Connector intended, or a stray change?
Contributor
Author
|
[gpt-5.4] @pvillard31 I addressed the follow-up feedback in
|
Preserve exact numeric precision when combining a count-only Backlog with a timestamp-only Backlog, and add focused tests for timestamp-only and negative-value cases. Also clean up related API JavaDocs and formatting surfaced during review.
markap14
force-pushed
the
api-connector-backlog
branch
from
33109c8 to
b33a3a1
Compare
pvillard31
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch